-
Notifications
You must be signed in to change notification settings - Fork 27
fix(specs): correct server URLs for Recommend #4595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think the Recommend API uses the same servers as the Search API.
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to ask confirmation to the recommend team or is this good to go?
|
Just to be safe, maybe let's ask them? |
|
cc @bengreenbank @raed667 🥺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇 LGTM 🥇
…ip ci] Co-authored-by: Kai Welke <[email protected]>
🧭 What and Why
Use the correct domains for the server URLs for the Recommend API.
If I remember correctly, they should be the same as the Search API.
🎟 JIRA Ticket:
Changes included:
🧪 Test