Skip to content

Conversation

@kai687
Copy link
Contributor

@kai687 kai687 commented Mar 14, 2025

🧭 What and Why

Use the correct domains for the server URLs for the Recommend API.
If I remember correctly, they should be the same as the Search API.

🎟 JIRA Ticket:

Changes included:

  • List changes

🧪 Test

I think the Recommend API uses the same servers as the Search API.
@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 14, 2025

✔️ Code generated!

Name Link
🪓 Triggered by d5fb4438febded0ea394e3f68f799deaf2a95375
🍃 Generated commit 664e51419912c167f92fe417c23b42751de6e153
🌲 Generated branch generated/fix/recommend-server-urls
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1657
go 1602
php 1446
csharp 1316
python 1074
java 1073
ruby 824
swift 374
scala 23

@kai687 kai687 marked this pull request as ready for review March 14, 2025 10:43
@kai687 kai687 requested a review from a team as a code owner March 14, 2025 10:43
@kai687 kai687 requested review from Fluf22 and millotp March 14, 2025 10:43
Copy link
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to ask confirmation to the recommend team or is this good to go?

@kai687
Copy link
Contributor Author

kai687 commented Mar 17, 2025

Just to be safe, maybe let's ask them?

@shortcuts
Copy link
Member

cc @bengreenbank @raed667 🥺

@bengreenbank
Copy link
Contributor

@raed667 is off this week so perhaps @benamib can answer? I'm unfamiliar with the Recommend API

Copy link
Contributor

@raed667 raed667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 LGTM 🥇

@shortcuts shortcuts merged commit d74532f into main Mar 18, 2025
28 checks passed
@shortcuts shortcuts deleted the fix/recommend-server-urls branch March 18, 2025 07:35
algolia-bot added a commit that referenced this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants